escape "|" inside parameters for API calls

[volker]

In [1]: from mwlib import wiki

In [2]: w=wiki.makewiki(':en')
2008-11-17T09:21:43 mwlib.utils.info >> fetching 'http://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&format=json'

In [3]: w.wiki.getTemplate("BSkm| - |2.6")
2008-11-17T09:21:48 mwlib.utils.info >> fetching 'http://en.wikipedia.org/w/api.php?redirects=1&titles=Template:PrintBSkm|+-+|2.6&format=json&action=query&rvprop=content&prop=revisions'
Out[3]: u"{{Wiktionarypar|-}}\n'''-''' may refer to:\n* [[Hyphen]]\n* [[Plus and minus signs#Minus_sign|Minus sign]]\n* [[Hyphen-minus]]\n\n===See also===\n* [[Dash]]\n\n{{disambig}}\n\n[[cs:-]]\n[[de:Strich]]\n[[eo:Streko]]\n[[es:-]]\n[[fr:-]]\n[[ko:-]]\n[[he:-]]"

[ralf]

happens when expanding

{{BSkm{{!}} - {{!}}2.6}}

[ralf]

mwlib:932e2df8a4f3

[jojo]

Replying to volker:

In [3]: w.wiki.getTemplate("BSkm| - |2.6")

Why's WikiDB.getTemplate() called with this title? Isn't the title of the template just "BKsm", the rest are positional args?

[jojo]

Got it. It's my bug.

Although I don't know, why this title is passed to getTemplate() in the first place (I also didn't really understand http://en.wikipedia.org/wiki/Template:!)

[ralf]

It's not called anymore with a pipe symbol...

[jojo]

Do you know if pipe symbols are allowed in regular titles (e.g. for articles etc.)?

[ralf]

no, they are not. trying to access Main|:

Bad title
From Testwiki
Jump to: navigation, search

The requested page title was invalid, empty, or an incorrectly linked inter-language or inter-wiki title. It may contain one or more characters which cannot be used in titles. 

[volker]

just to clarify how the situation happend, this is how the markup looked like. btw. the markup does not display correctly in the mediawiki.

{{BS5|tCPICl|tCPICrSTR{{BSkm{{!}} - {{!}}2.6}}|{{ja-stalink|Kotake-Mukaihara}}| (Y-06)|}}

[jojo]

Replying to volker:

just to clarify how the situation happend, this is how the markup looked like. btw. the markup does not display correctly in the mediawiki.

If it doesn't work in MediaWiki, I guess we can close this as wontfix.

[volker]

the problem is the way it fails in mediawiki and how it fails with the parser:

the mediawiki pretty much just interprets the whole thing as plain text. the mwlib parser in contrast expands it in a faulty way, with the result that an enormous amount of other templates are included. --> the parser adds content that is not there. therefore I still think this is a serious problem that should be fixed. also the parsetree contains total bogus which can not be rendered by the writers

[jojo]

Replying to volker:

the mwlib parser in contrast expands it in a faulty way, with the result that an enormous amount of other templates are included.

Shouldn't happen anymore after Ralf's changeset.